Skip to content

✨ feat(validate-news): skip labels set at opening - #40

Merged
gaborbernat merged 1 commit into
mainfrom
news-skip-opening-labels
Nov 2, 2026
Merged

✨ feat(validate-news): skip labels set at opening#40
gaborbernat merged 1 commit into
mainfrom
news-skip-opening-labels

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Nov 2, 2026

Copy link
Copy Markdown
Member

Opening a pull request with labels, as gh pr create --label does, fires labeled a moment after opened. Callers trigger the news check on both, so it ran twice, and callers whose news.yaml cancels runs in progress showed the cancelled run as a failed 📝 News fragment check while the other passed. 🏷️

validate-news now passes at once for a label added or removed within a minute of the pull request opening. The run for opened already reads the labels from the API when it checks, so a skip news label applied at opening still counts there. Label changes after that first minute run the full check as before, so adding or removing skip news later still updates the required status.

The README now tells callers not to cancel runs in progress, since cancelling is what turned the duplicate into a red check. Callers pick this up by moving their pin to the next release and dropping the concurrency block from news.yaml; the check keeps its 📝 News fragment name, so rulesets need no change.

@gaborbernat gaborbernat added the enhancement New feature or request label Nov 2, 2026
@gaborbernat
✨ feat(validate-news): skip labels set at opening
39e5fae 
`gh pr create --label` labels a pull request right after opening it, so
callers triggered on `labeled` ran the check twice, and those that cancel
runs in progress showed the cancelled run as a failed check. A label event
within a minute of opening now passes at once: the run for `opened` reads
the labels from the API when it checks, so it already covers that label.
@gaborbernat
gaborbernat force-pushed the news-skip-opening-labels branch from 9e37074 to 39e5fae Compare November 2, 2026 19:04
@gaborbernat
gaborbernat merged commit ee3584d into main Nov 2, 2026
10 checks passed
@gaborbernat
gaborbernat deleted the news-skip-opening-labels branch November 2, 2026 19:09
This was referenced Nov 2, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 2, 2026
Merged
Merged
gaborbernat added a commit to tox-dev/sphinx-autodoc-typehints that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#1109)
eeec594 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/pre-commit-uv that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#200)
68c1734 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/action-pre-commit-uv that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#52)
17b9a0e 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/tox-uv that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#406)
9691f91 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to pytest-dev/pytest-print that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#285)
2863bf6 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/sphinx-argparse-cli that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#386)
ef95848 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/python-discovery that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#184)
0042949 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/devpi-process that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#302)
ab51ba5 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/tox-ini-fmt that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#394)
138f80f 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to gaborbernat/bump-deps-index that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#295)
cf4df6d 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to gaborbernat/mdformat-hugo that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#56)
5a2458b 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/mdformat-zola that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#49)
b5bbb5d 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/PyVenvManage that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#287)
887ac98 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/toml-fmt that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#504)
f09ff5b 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

Runs no longer cancel each other, and the check reads the pull request's
labels from the API instead of the event, so the run for opening sees a
`skip news` label added with it and both runs agree. The
`github-workflows` pin moves to
[6.3.0](tox-dev/github-workflows#40). The check
keeps its name, so the ruleset needs no change.
gaborbernat added a commit to tox-dev/jetbrains-fish that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#163)
6dff3e7 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to pypa/pipx that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#2406)
1e4a6a6 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/platformdirs that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#680)
eb0cce8 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/filelock that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#901)
4257ca7 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/pyproject-api that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#346)
8e123df 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to pytest-dev/pytest-env that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#295)
71cfbc5 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/pipdeptree that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#866)
b3ab096 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/tox-gh that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#320)
c088bf7 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to gaborbernat/pypi-changes that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#288)
1de3087 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/xml-fmt that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#137)
d2798ff 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to pypa/virtualenv that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#3495)
fd8e6d4 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to quotaline/quotaline that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): keep label runs from cancelling (#23)
0856dbd 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the shared concurrency group cancelled the first run, which the PR
then listed as a failed `📝 News fragment` check while the other run
passed. 👷

Label events now get their own concurrency group, so they no longer
cancel the run for opening while a new push still cancels a superseded
run, as the repository's workflow lint requires. The check moves to
[github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening. The check keeps its name, so the ruleset needs no change.
gaborbernat added a commit to tox-dev/turbohtml that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#1559)
4c1ae16 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

This moves the news check to [github-workflows
6.3.0](tox-dev/github-workflows#40), whose
`validate-news` passes at once for a label set within a minute of
opening since the run for opening already reads the current labels, and
stops cancelling runs in progress. The check keeps its name, so the
ruleset needs no change.
gaborbernat added a commit to tox-dev/peryx that referenced this pull request Nov 2, 2026
@gaborbernat
👷 ci(news): stop cancelling the news check (#2399)
c7ea311 
Opening a pull request with labels, as `gh pr create --label` does,
fires `labeled` a moment after `opened`. Both started the news check,
and the concurrency group cancelled the first run, which the PR then
listed as a failed `📝 News fragment` check while the other run passed. 👷

Runs no longer cancel each other, and the check reads the pull request's
labels from the API instead of the event, so the run for opening sees a
`skip news` label added with it and both runs agree. The
`github-workflows` pin moves to
[6.3.0](tox-dev/github-workflows#40). The check
keeps its name, so the ruleset needs no change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gaborbernat